]> dgit.raspbian.org Git - gnome-shell.git/commit
calendar: do not call destroy() recursively
authorCosimo Cecchi <cosimo@endlessm.com>
Thu, 11 Oct 2018 02:08:38 +0000 (19:08 -0700)
committerFlorian Müllner <florian.muellner@gmail.com>
Sat, 10 Nov 2018 10:56:49 +0000 (10:56 +0000)
commit5fb8d4f730a176cb55e8e6c11072595972be6485
tree51bab19f0e6c474a91fc5006307cbc9201ae0b9a
parenta98ed08a549bcc2fdc0b9c1b50edd3d83dd3c06d
calendar: do not call destroy() recursively

We have a callback that will call close() when the notification is
destroyed, and a callback that will call destroy() on the notification
when the message is closed.

Currently, if the notification is destroyed we'll execute our callback
that will call again destroy() on the notification. That's bad
practice in general, and it also has the side effect of resetting the
destroy reason.

This commit avoids re-destroying the notification by dropping the
notification reference on destroy.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/258
js/ui/calendar.js